Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PositivityToricBundles to v1.8 #3357

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Update PositivityToricBundles to v1.8 #3357

merged 3 commits into from
Aug 5, 2024

Conversation

a-hochenegger
Copy link
Contributor

Fixed a bug in an internal method used for compatibleBases and toricChernCharacter:
the method made an assumption on the form how the filtration steps are ordered in the bundles generated by the package ToricVectorBundles. Usually true, this assumption does not apply, if the bundle arises by using the method dual of ToricVectorBundles (e.g. cotangent bundles).

@mahrud
Copy link
Member

mahrud commented Jul 27, 2024

Could you add an example where the previous version fails as an additional test?

@a-hochenegger
Copy link
Contributor Author

a-hochenegger commented Jul 27, 2024 •
edited
Loading

There is now such a test (that would have failed in the previous versions).

@d-torrance d-torrance changed the base branch from master to development August 2, 2024 11:12
@a-hochenegger @d-torrance
Update PositivityToricBundles to v1.8
2581959
@a-hochenegger @d-torrance
Minor update PositivityToricBundles v1.8
6750eac 
Added a test that would fail with v1.7, see description of previous commit with update to v1.8.
@a-hochenegger @d-torrance
Minor: updated version number to 1.8
40bedeb
@d-torrance
Copy link
Member

I think the macOS builds were failing because this PR originally targeted master and so an older version of factory w/o FLINT 3 support was being built. I just rebased it on top of development, which should fix this.

@a-hochenegger
Copy link
Contributor Author

a-hochenegger commented Aug 2, 2024 •
edited
Loading

@d-torrance thank you very much! I was already wondering about this failing builds (but I had no idea how my changes could have caused them). In order to avoid these errors in the future: should I always choose development as the target of my pull requests?

@d-torrance
Copy link
Member

Yes, always target development for new pull requests. (If you forget, then one of us will likely change it for you so it gets merged into the correct branch. But that doesn't help tests, unfortunately.)

@d-torrance d-torrance merged commit 67f9e5c into Macaulay2:development Aug 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-hochenegger @mahrud @d-torrance